Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test and freshness on_warning_callback #1408

Open
pankajastro opened this issue Dec 18, 2024 · 1 comment
Open

Improve test and freshness on_warning_callback #1408

pankajastro opened this issue Dec 18, 2024 · 1 comment
Labels
area:parsing Related to parsing DAG/DBT improvement, issues, or fixes dbt:test Primarily related to dbt test command or functionality stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed

Comments

@pankajastro
Copy link
Contributor

pankajastro commented Dec 18, 2024

Cosmos, at the moment, triggers on_warning_callback on dbt test even if it sees a "warn" message in logs. I believe we can improve our log parsing to avoid it and control it better. The parsing code is at https://github.com/astronomer/astronomer-cosmos/blob/main/cosmos/dbt/parser/output.py

Example

Test warn

1 of 1 WARN 1 unique_stg_green_taxi_color ...................................... [WARN 1 in 2.14s]

freshness warn

 1 of 1 WARN freshness of postgres_db.raw_orders ................................ [WARN in 0.02s]
@dosubot dosubot bot added area:parsing Related to parsing DAG/DBT improvement, issues, or fixes dbt:test Primarily related to dbt test command or functionality labels Dec 18, 2024
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:parsing Related to parsing DAG/DBT improvement, issues, or fixes dbt:test Primarily related to dbt test command or functionality stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed
Projects
None yet
Development

No branches or pull requests

1 participant