Fix CI issues - Upgrade actions/upload-artifact & actions/download-artifact to v4 and set min version for packaging #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
pankajkoti
changed the title
pankajkoti
commented
Sep 18, 2024
Co-authored-by: Pankaj Koti <[email protected]>
|
Thanks a lot for working on this, @pankajkoti , and solving the CI issue proactively while we were at the Airflow Summit! |
tatiana
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Thanks a lot, @pankajkoti , given our discussion with TP on #1201 (comment), this seems the best way to move forward.
dosubot
bot
added
size:S
2 tasks
ags-de
pushed a commit
to ags-de/astronomer-cosmos
that referenced
this pull request
Sep 24, 2024
…tifact to v4 and set min version for packaging (astronomer#1208) I am observing that our CI [jobs](https://github.com/astronomer/astronomer-cosmos/actions/runs/10920015707/job/30308959677?pr=1207) are failing complaining that we're using deprecated version (v2) for `actions/upload-artifact` & `actions/download-artifact`. It is weird that the jobs directly are failed for using deprecating versions, but so is the case that's happening. Hence, to get the CI working I'm upgrading the versions to use v4. Additionally, we are observing failures for packaging version as discussed in astronomer#1201 (comment). Hence, also set the min packaging version to `22.0` as per the discussion in that thread closes: astronomer#1209 --------- Co-authored-by: Tatiana Al-Chueyr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am observing that our CI jobs are failing complaining that we're using deprecated version (v2) for
actions/upload-artifact&actions/download-artifact. It is weird that the jobs directly are failed for using deprecating versions, but so is the case that's happening. Hence, to get the CI working I'm upgrading the versions to use v4.Additionally, we are observing failures for packaging version as discussed in #1201 (comment). Hence, also set the min packaging version to
22.0as per the discussion in that threadcloses: #1209