Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run margin generation within the main import pipeline #384

Open
1 of 3 tasks
hombit opened this issue Aug 23, 2024 · 0 comments
Open
1 of 3 tasks

Run margin generation within the main import pipeline #384

hombit opened this issue Aug 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@hombit
Copy link
Contributor

hombit commented Aug 23, 2024

Feature request

I believe that margin generation should become more implicit and happen by default for every hipscat-import. I propose falling changes:

  1. Generate margins with default 10'' margin_threshold within the "main" importing pipeline. This should be the default, however we still may allow a separate margin generation pipeline to a) generate more caches, b) split the pipeline for large/complicated imports.
  2. Turn off fine filtering by default

Before submitting
Please check the following:

  • I have described the purpose of the suggested change, specifying what I need the enhancement to accomplish, i.e. what problem it solves.
  • I have included any relevant links, screenshots, environment information, and data relevant to implementing the requested feature, as well as pseudocode for how I want to access the new functionality.
  • If I have ideas for how the new feature could be implemented, I have provided explanations and/or pseudocode and/or task lists for the steps.
@hombit hombit added the enhancement New feature or request label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant