Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

margin_threshold metadata property not set correctly if margin_order parameter is used in generation #439

Open
smcguire-cmu opened this issue Nov 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@smcguire-cmu
Copy link
Contributor

In margin generation, if the margin_order parameter is set, then the margin_threshold parameter is ignored and the margin is generated using pixels of the margin_order. But the margin_threshold property in the properties file is still set based on the ignored margin threshold. It would be useful to set this as the minimum pixel distance for the margin order.

@nevencaplar nevencaplar added the bug Something isn't working label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants