Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for indexed readers #30

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Tests for indexed readers #30

merged 1 commit into from
Jun 14, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Adds a test that passes storage options to indexed file reads.

The parquet dataset reading in particular is finnicky, and I wanted to make sure we were doing it right (because this took some extra plumbing to achieve).

See:

Copy link

Before [4b2e63b] After [c346fda] Ratio Benchmark (Parameter)
544 3.76k 6.91 benchmarks.mem_list
3.68±0.4s 3.98±1s 1.08 benchmarks.time_computation

Click here to view all benchmarks.

tests/conftest.py Show resolved Hide resolved
@delucchi-cmu delucchi-cmu merged commit 73ac873 into main Jun 14, 2024
7 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/hipscat/308/indexed branch June 14, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants