Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test catalog import. #4

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Test catalog import. #4

merged 2 commits into from
Dec 8, 2023

Conversation

delucchi-cmu
Copy link
Contributor

Closes #3.

Adds a couple end-to-end tests that

  • read data from the cloud and create a new catalog locally
  • read data locally and create a new catalog in the cloud

src/hipscat_cloudtests/file_checks.py Show resolved Hide resolved
tests/hipscat_import/conftest.py Show resolved Hide resolved
tests/hipscat_import/conftest.py Outdated Show resolved Hide resolved
@camposandro
Copy link
Contributor

Oh also, the asv workflows are failing because they are not installing the dependencies declared in requirements.txt. Setting up a custom install_command on asv.conf.json should hopefully resolve this issue :)

"install_command": [
    "python -mpip install -r requirements.txt {wheel_file}"
]

@delucchi-cmu
Copy link
Contributor Author

Oh also, the asv workflows are failing because they are not installing the dependencies declared in requirements.txt. Setting up a custom install_command on asv.conf.json should hopefully resolve this issue :)

"install_command": [
    "python -mpip install -r requirements.txt {wheel_file}"
]

Thanks! Added

Copy link

github-actions bot commented Dec 8, 2023

Before [41934ed] After [488d24d] Ratio Benchmark (Parameter)
4.44±0.8s 1.27±0.6s ~0.29 benchmarks.time_computation
3.18k 4.11k 1.29 benchmarks.mem_list

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu merged commit 4c7518b into main Dec 8, 2023
8 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/3/import branch January 11, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration tests for hipscat-import catalog creation
2 participants