Restructure exception handling

astronomy-commons · Nov 29, 2023 · 0b77517 · 0b77517
1 parent 2da502c
commit 0b77517
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/hipscat_import/pipeline.py b/src/hipscat_import/pipeline.py
@@ -55,15 +55,15 @@ def pipeline_with_client(args: RuntimeArguments, client: Client):
             macauff_runner.run(args, client)
         else:
             raise ValueError("unknown args type")
-    except Exception as exception:  # pylint: disable=broad-exception-caught
-        _send_failure_email(args, exception)
-    else:
+
         _send_success_email(args)
+    except Exception as exception:  # pylint: disable=broad-exception-caught
+        if args.completion_email_address:
+            _send_failure_email(args, exception)
+        raise exception
 
 
 def _send_failure_email(args: RuntimeArguments, exception: Exception):
-    if not args.completion_email_address:
-        raise exception from None
     message = EmailMessage()
     message["Subject"] = "hipscat-import failure."
     message["To"] = args.completion_email_address