Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of metadata file conversion #156

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Conversation

delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented Oct 31, 2023

Change Description

Part of Issue #147 - methods to convert macauff xml or yaml metadata files into parquet metadata files.

This also sneaks in a refactor of input file location to appease pylint.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #156 (02d9dd3) into main (46ee668) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        27    +1     
  Lines         1102      1146   +44     
=========================================
+ Hits          1102      1146   +44     
Files Coverage Δ
src/hipscat_import/catalog/arguments.py 100.00% <100.00%> (ø)
...rc/hipscat_import/cross_match/macauff_arguments.py 100.00% <100.00%> (ø)
src/hipscat_import/cross_match/macauff_metadata.py 100.00% <100.00%> (ø)
src/hipscat_import/runtime_arguments.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@delucchi-cmu delucchi-cmu merged commit 0629cb4 into main Nov 2, 2023
13 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/metadata branch November 2, 2023 16:56
delucchi-cmu added a commit that referenced this pull request Nov 6, 2023
* Set lower default import order. (#153)

* Macauff pipeline boilerplate (#152)

* checkpoint

* checkpoint

* testing for MacauffArguments

* create boilerplate for macauff runner + tests

* remove commented out test

* add __future__.annotations

* linter problems

* add more tests for missing coverage

* refactor MacauffArguments required parameter tests

* address more comments from pr #152

* add dask pytest mark + black formatting

* Add a partition_info on SOAP results. (#157)

* Initial commit of metadata file conversion (#156)

* Initial commit of metadata file conversion

* Move shared logic for locating input files.

* Explicitly depend on pyyaml

---------

Co-authored-by: Max West <[email protected]>
delucchi-cmu added a commit that referenced this pull request Nov 6, 2023
* Use existing hipscat_index for mapping pixel

* Update required version.

* Merge recent changes (#163)

* Set lower default import order. (#153)

* Macauff pipeline boilerplate (#152)

* checkpoint

* checkpoint

* testing for MacauffArguments

* create boilerplate for macauff runner + tests

* remove commented out test

* add __future__.annotations

* linter problems

* add more tests for missing coverage

* refactor MacauffArguments required parameter tests

* address more comments from pr #152

* add dask pytest mark + black formatting

* Add a partition_info on SOAP results. (#157)

* Initial commit of metadata file conversion (#156)

* Initial commit of metadata file conversion

* Move shared logic for locating input files.

* Explicitly depend on pyyaml

---------

Co-authored-by: Max West <[email protected]>

* Exercise more hipscat_index behavior.

---------

Co-authored-by: Max West <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants