-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use existing hipscat_index for mapping pixel #159
Conversation
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
===========================================
- Coverage 100.00% 99.74% -0.26%
===========================================
Files 24 27 +3
Lines 1022 1156 +134
===========================================
+ Hits 1022 1153 +131
- Misses 0 3 +3
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I run this branch for SFD map importing and it worked fine!
The only real issue from listed bellow is the hipscat
version requirement.
* Set lower default import order. (#153) * Macauff pipeline boilerplate (#152) * checkpoint * checkpoint * testing for MacauffArguments * create boilerplate for macauff runner + tests * remove commented out test * add __future__.annotations * linter problems * add more tests for missing coverage * refactor MacauffArguments required parameter tests * address more comments from pr #152 * add dask pytest mark + black formatting * Add a partition_info on SOAP results. (#157) * Initial commit of metadata file conversion (#156) * Initial commit of metadata file conversion * Move shared logic for locating input files. * Explicitly depend on pyyaml --------- Co-authored-by: Max West <[email protected]>
Change Description
Partially addresses issue #46 by allowing for import partitioning by a previously-computed
_hipscat_index
column.Code Quality