Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument renaming #168

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Argument renaming #168

merged 1 commit into from
Nov 21, 2023

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Four refactors bundled up here:

  • renames the argument output_catalog_name to output_artifact_name (see Verification pipeline boilerplate #126)
  • renames catalog import argument id_column to sort_columns (this field need not be an id (could be time), and can support more than one column)
  • clarifies the type for sort_columns (was mixing str and List[str])
  • runs black and isort

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

hombit
hombit approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the context of catalog -> artifact, but everything looks great to me!

@delucchi-cmu delucchi-cmu merged commit 9f44b40 into main Nov 21, 2023
11 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/rename branch November 22, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hombit hombit hombit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delucchi-cmu @hombit