Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another test for creating index table. #190

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

I woke up bothered because something should have failed prior to #189.

All Norder/Npix values happened to be the same because we were only testing with a primary catalog with a single Norder/Npix. Using a catalog with mixed Norder/Npix would fail when writing parquet metadata, unless setting order_by_healpix=False, which is added in PR #189.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c96627a) 99.76% compared to head (d242594) 99.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          27       27           
  Lines        1273     1273           
=======================================
  Hits         1270     1270           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu merged commit 413c8b1 into main Dec 13, 2023
13 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/index branch December 14, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants