Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements for index generation #202

Merged
merged 8 commits into from
Feb 2, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Related to astronomy-commons/lsdb#108

This improves the performance of generating indexes for very large datasets.

  • adds optional division hints for setting the new index
  • adds option to skip drop_duplicates operation
  • sneaks in a quality-of-life improvement when running pytest on epyc: the last test would often fail as a timeout.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (862ea03) 99.74% compared to head (ea6c049) 99.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          24       24           
  Lines        1166     1176   +10     
=======================================
+ Hits         1163     1173   +10     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spending some time on the groupby suggestion, I think this looks good!

@delucchi-cmu delucchi-cmu merged commit 0ae6657 into main Feb 2, 2024
13 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/108/index_divisions branch February 2, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants