Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand docs for margin and index generation. #212

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Gives all the help I can think to give when generating margin caches or index tables.

Note that this duplicates A LOT of the text between catalogs/arguments.rst, guide/margin_cache.rst and guide/index_table.rst. This is intentional, and based on feedback I got from Troy about duplicating some argument specifications instead of making users look in a few different places to put their pipeline together.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a2d119) 99.74% compared to head (239fa7f) 99.74%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          24       24           
  Lines        1186     1186           
=======================================
  Hits         1183     1183           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nevencaplar nevencaplar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful. Let us merge this!

@delucchi-cmu delucchi-cmu merged commit 6eb5204 into main Feb 12, 2024
13 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/margin_docs branch February 12, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants