Add ECSV reader #288
Merged
Add ECSV reader #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
=======================================
Coverage 99.35% 99.36%
=======================================
Files 24 24
Lines 1246 1260 +14
=======================================
+ Hits 1238 1252 +14
Misses 8 8 ☔ View full report in Codecov by Sentry. |
hombit
requested changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #225
Adds basic support for an ECSV reader. Note that the astropy ecsv reader does not implement a "fast" reader, so this method is not sped up by underlying C++, and it is not possible to chunk the reads into smaller tables.
See: https://docs.astropy.org/en/stable/io/ascii/read.html#reading-large-tables-in-chunks