Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User arguments to retain intermediate files #311

Merged
merged 1 commit into from
May 16, 2024

Conversation

delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented May 15, 2024

Closes #297

Solution Description

Exposes an existing internal testing parameter to keep the intermediate parquet shard files.

In addition, creates new option to keep the intermediate resume logging files.

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.53%. Comparing base (3f7a423) to head (7f6bb55).
Report is 52 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #311   +/-   ##
=======================================
  Coverage   99.52%   99.53%           
=======================================
  Files          25       25           
  Lines        1274     1282    +8     
=======================================
+ Hits         1268     1276    +8     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu merged commit 06b8379 into main May 16, 2024
9 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/297/retain_files branch May 16, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose arguments to NOT delete intermediate files
2 participants