Spruce up the way we check for original input files.

[delucchi-cmu]

Change Description

Closes #299

Solution Description

Converts paths to strings before performing comparison, so plain-text strings and Pathlib objects can be compared reasonably. Also, converts both sides into lists for comparisons.

Code Quality

• I have read the Contribution Guide and LINCC Frameworks Code of Conduct
• My code follows the code style of this project
• My code builds (or compiles) cleanly without any errors or warnings
• My code contains relevant comments and necessary documentation

Bug Fix Checklist

• My fix includes a new test that breaks as a result of the bug (if possible)
• My change includes a breaking change
  • My change includes backwards compatibility and deprecation warnings (if possible)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.52%. Comparing base (8b19bc2) to head (2b1dd4d).
Report is 49 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #314   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files          25       25           
  Lines        1270     1270           
=======================================
  Hits         1264     1264           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[camposandro]

Looks good to me!

I just have a small question, should we be writing the set of unique paths, unique_file_paths, instead of input_paths to disk? It doesn't really change the behavior in this case since we create a set on read but it might improve readability.

hipscat-import/src/hipscat_import/pipeline_resume_plan.py

Lines 190 to 193 in 48dc9ac

	file_path = file_io.append_paths_to_pointer(self.tmp_path, self.ORIGINAL_INPUT_PATHS)
	with open(file_path, "w", encoding="utf-8") as file_handle:
	for path in input_paths:
	file_handle.write(f"{path}\n")

[delucchi-cmu]

Looks good to me!

I just have a small question, should we be writing the set of unique paths, unique_file_paths, instead of input_paths to disk? It doesn't really change the behavior in this case since we create a set on read but it might improve readability.

hipscat-import/src/hipscat_import/pipeline_resume_plan.py

Lines 190 to 193 in 48dc9ac

	file_path = file_io.append_paths_to_pointer(self.tmp_path, self.ORIGINAL_INPUT_PATHS)
	with open(file_path, "w", encoding="utf-8") as file_handle:
	for path in input_paths:
	file_handle.write(f"{path}\n")

I think it would change the behavior, but only in that it would be more correct. Since we're sorting and de-duping before we check, we should use the results of those operations in the write-to-disk.