Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail fast on reduce stage failures. #317

Merged
merged 2 commits into from
May 22, 2024
Merged

Fail fast on reduce stage failures. #317

merged 2 commits into from
May 22, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Closes #300.

Adds code path for the waiting for futures operation to re-raise exception on the first exception encountered. The reducing stage is a little unique, in that a failure in some shard indicates that the whole pipeline may be experiencing issues, whereas failures at mapping and splitting are more likely to indicate a problem with an individual file.

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.52%. Comparing base (37ce248) to head (63e8684).
Report is 48 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #317   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files          25       25           
  Lines        1270     1272    +2     
=======================================
+ Hits         1264     1266    +2     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu merged commit 793212f into main May 22, 2024
9 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/300/fail_fast branch May 22, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce stage should fail faster if any individual task fails
2 participants