Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print file name for mapping/splitting failures. #318

Merged
merged 5 commits into from
May 24, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Closes #301

Uses dask's distributed print call to log any exception encountered in tasks. This allows for some custom formatting, including the name of the input file, or reference to healpix shard.

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 98.58156% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 99.53%. Comparing base (793212f) to head (fc5bd4b).

Files Patch % Lines
src/hipscat_import/soap/map_reduce.py 96.22% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   99.52%   99.53%           
=======================================
  Files          25       25           
  Lines        1272     1292   +20     
=======================================
+ Hits         1266     1286   +20     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

Attention: Patch coverage is 98.62069% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.53%. Comparing base (793212f) to head (7064f1a).
Report is 49 commits behind head on main.

Files Patch % Lines
src/hipscat_import/soap/map_reduce.py 96.07% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   99.52%   99.53%           
=======================================
  Files          25       25           
  Lines        1272     1293   +21     
=======================================
+ Hits         1266     1287   +21     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu merged commit c3fda23 into main May 24, 2024
8 of 9 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/301/print branch May 24, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print input file for failed map/split stages
3 participants