Explicitly depend on scipy #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
=======================================
Coverage 99.53% 99.53%
=======================================
Files 25 25
Lines 1293 1293
=======================================
Hits 1287 1287
Misses 6 6 ☔ View full report in Codecov by Sentry. |
camposandro
approved these changes
May 28, 2024
delucchi-cmu
added a commit
to regro-cf-autotick-bot/hipscat-import-feedstock
that referenced
this pull request
Jun 3, 2024
Explicitly depend on scipy see astronomy-commons/hats-import#320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
healpy is re-arranging dependencies, and scipy is now an optional dependency. We depend on it, outside of healpy functionality, and should explicitly add to dependency list.