Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redact storage options, as this may include user keys. #322

Merged
merged 2 commits into from
May 29, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

The storage_options kwarg is very likely to contain sensitive user information, like API keys. Adds logic to suppress their storage in the provenance_info.json file.

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.53%. Comparing base (e11308f) to head (85749f3).
Report is 53 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #322   +/-   ##
=======================================
  Coverage   99.53%   99.53%           
=======================================
  Files          25       25           
  Lines        1293     1296    +3     
=======================================
+ Hits         1287     1290    +3     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu merged commit daad9df into main May 29, 2024
9 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/user_pii branch May 29, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants