Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickle instead of scatter. #328

Merged
merged 5 commits into from
Jun 6, 2024
Merged

Pickle instead of scatter. #328

merged 5 commits into from
Jun 6, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Closes #302.

Writes the file reader to a pickled file, and de-pickles in the mapping and splitting workers.

Writes the alignment to a pickled file, and de-pickles in the splitting workers. destination map is created on-demand, and is owned by the resume plan, as this is used to determine remaining reduce tasks.

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.78%. Comparing base (c5e6095) to head (a66e111).
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   99.56%   99.78%   +0.21%     
==========================================
  Files          26       26              
  Lines        1379     1389      +10     
==========================================
+ Hits         1373     1386      +13     
+ Misses          6        3       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/hipscat_import/catalog/resume_plan.py Outdated Show resolved Hide resolved
src/hipscat_import/catalog/resume_plan.py Outdated Show resolved Hide resolved
src/hipscat_import/catalog/resume_plan.py Outdated Show resolved Hide resolved
src/hipscat_import/catalog/resume_plan.py Outdated Show resolved Hide resolved
src/hipscat_import/catalog/resume_plan.py Show resolved Hide resolved
@delucchi-cmu delucchi-cmu merged commit 3b2c3ae into main Jun 6, 2024
9 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/302/pickle branch June 6, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly write to disk instead of client.scatter
2 participants