Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "index file" reads for catalog import #334

Merged
merged 6 commits into from
Jun 12, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Closes #308 .

Solution Description

Creates a new kind of file reader for catalog import: indexed file reader. This uses a single "index" file as a task unit, and these files contain only paths to data files to be read. This enables batching many small input data files into larger chunks for the map and reduce stages of the pipeline.

Implements an indexed reader for CSV and for Parquet files. In particular, the parquet reader utilizes pyarrow's parquet read batch_readahead, fragment_readahead, and multi-threading to further speed up reads of many small data files.

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.79%. Comparing base (04c1a8f) to head (c45a6dc).
Report is 40 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage   99.78%   99.79%           
=======================================
  Files          26       26           
  Lines        1389     1442   +53     
=======================================
+ Hits         1386     1439   +53     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jeremykubica jeremykubica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two high level questions.

src/hipscat_import/catalog/file_readers.py Show resolved Hide resolved
src/hipscat_import/catalog/file_readers.py Show resolved Hide resolved
@delucchi-cmu delucchi-cmu merged commit 33d70e7 into main Jun 12, 2024
9 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/308/indexed branch June 12, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement file-list-batch style catalog import
3 participants