Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only specify the astropy table columns once. #336

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Closes #335 .

When passing read_columns (as in the mapping stage), do not attempt to further limit the columns read from the fits file.

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.79%. Comparing base (22cba75) to head (5337ca9).
Report is 39 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files          26       26           
  Lines        1442     1442           
=======================================
  Hits         1439     1439           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu requested a review from hombit June 14, 2024 14:43
Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@delucchi-cmu delucchi-cmu merged commit de8799c into main Jun 14, 2024
9 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/335/fits branch June 14, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FitsReader fails when skip_column_names is not None
2 participants