From a7bbb144682f6d3c65084bab7d2dc740702ee971 Mon Sep 17 00:00:00 2001 From: Brett Date: Wed, 10 Sep 2025 08:59:53 -0400 Subject: [PATCH 1/2] increase minimum asdf and astropy --- .../converters/unit/tests/test_quantity.py | 15 ++++----------- pyproject.toml | 4 ++-- 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/asdf_astropy/converters/unit/tests/test_quantity.py b/asdf_astropy/converters/unit/tests/test_quantity.py index 1d3bb66c..5c0c6f06 100644 --- a/asdf_astropy/converters/unit/tests/test_quantity.py +++ b/asdf_astropy/converters/unit/tests/test_quantity.py @@ -4,18 +4,11 @@ from asdf.testing import helpers from astropy import units from astropy.units import Quantity -from astropy.utils.introspection import minversion from numpy.testing import assert_array_equal from asdf_astropy.tests.versions import ASTROPY_GE_7_1 -def asdf_open_memory_mapping_kwarg(memmap: bool) -> dict: - if minversion("asdf", "3.1.0"): - return {"memmap": memmap} - return {"copy_arrays": not memmap} - - def create_quantities(): return [ # Scalar: @@ -104,7 +97,7 @@ def test_memmap(tmp_path): af.write_to(file_path) # Update a value in the ASDF file - with asdf.open(file_path, mode="rw", **asdf_open_memory_mapping_kwarg(memmap=True)) as af: + with asdf.open(file_path, mode="rw", memmap=True) as af: assert (af.tree["quantity"] == quantity).all() assert af.tree["quantity"][-1, -1] != new_value @@ -114,7 +107,7 @@ def test_memmap(tmp_path): assert (af.tree["quantity"] != quantity).any() assert (af.tree["quantity"] == new_quantity).all() - with asdf.open(file_path, mode="rw", **asdf_open_memory_mapping_kwarg(memmap=True)) as af: + with asdf.open(file_path, mode="rw", memmap=True) as af: assert af.tree["quantity"][-1, -1] == new_value assert (af.tree["quantity"] != quantity).any() assert (af.tree["quantity"] == new_quantity).all() @@ -137,7 +130,7 @@ def test_no_memmap(tmp_path): af.write_to(file_path) # Update a value in the ASDF file - with asdf.open(file_path, mode="rw", **asdf_open_memory_mapping_kwarg(memmap=False)) as af: + with asdf.open(file_path, mode="rw", memmap=False) as af: assert (af.tree["quantity"] == quantity).all() assert af.tree["quantity"][-1, -1] != new_value @@ -147,7 +140,7 @@ def test_no_memmap(tmp_path): assert (af.tree["quantity"] != quantity).any() assert (af.tree["quantity"] == new_quantity).all() - with asdf.open(file_path, mode="rw", **asdf_open_memory_mapping_kwarg(memmap=False)) as af: + with asdf.open(file_path, mode="rw", memmap=False) as af: assert af.tree["quantity"][-1, -1] != new_value assert (af.tree["quantity"] != new_quantity).any() assert (af.tree["quantity"] == quantity).all() diff --git a/pyproject.toml b/pyproject.toml index 7bc80dca..153e692f 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -14,11 +14,11 @@ dynamic = [ 'version', ] dependencies = [ - "asdf>=2.15.0", + "asdf>=3.3.0", "asdf-coordinates-schemas>=0.4", "asdf-transform-schemas>=0.6", "asdf-standard>=1.1.0", - "astropy>=5.2.0", + "astropy>=5.3.0", "numpy>=1.26", "packaging>=19", ] From c6ee771a43817b0b804e2db2a85c69817bdae078 Mon Sep 17 00:00:00 2001 From: Brett Date: Wed, 10 Sep 2025 09:13:08 -0400 Subject: [PATCH 2/2] add changelog --- CHANGES.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGES.rst b/CHANGES.rst index 7c39f22b..a27609af 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -2,6 +2,7 @@ ------------------ - drop support for numpy 1.25. [#285] +- require asdf 3.3 and drop support for astropy 5.2 [#297] 0.8.0 (2025-06-11) ------------------