Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-ascii characters in sites.json (when enough astropy user base supports it) #40

Open
eteq opened this issue Jan 21, 2018 · 2 comments

Comments

@eteq
Copy link
Member

eteq commented Jan 21, 2018

#38 fixed an issue described in #36 where astropy doesn't correctly parse the sites.json file when it has non-ascii characters. While #38 fixes it, it does so by removing some characters that are proper names that really ought to be unicode. astropy/astropy#7082 fixes the underlying problem by making everything unicode-compliant in astropy. So this issue is about esentially reverting #38, and, more broadly, allowing UTF-8 in the site.json file.

We do not want to do this yet, however, as it will instantly break all released astropys (at the time of this writing). So instead, we are thinking to follow the suggestion of #36 (comment) - wait a while until we think most installed astropy have the fix (could be a long time...), and then bring in the non-ascii characters again.

@pllim
Copy link
Member

pllim commented Jan 22, 2018

Does this mean we can put emoji into observatory data? :trollface:

@aarchiba
Copy link

aarchiba commented Sep 2, 2019

JSON is capable of escaping non-ascii characters, and the python json module makes this easy. Would it solve the problems if this repository's contents contained only escaped Unicode? Or do old versions of astropy fail when the decoded data isn't Unicode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants