-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forwardport PR 261 to main (ALOHA 2024: Clean up photometry contents) #264
base: main
Are you sure you want to change the base?
Conversation
ALOHA 2024: Clean up photometry contents
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I did not check all of the new links but did spot check a couple, which worked.
Is there a way to run link check on all the workshop notebooks going forward? 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that 25.9463 is the 2012 zeropoint, but the change here to 25.936 doesn't agree with the current zeropoint calculated in stsynphot.
I get 25.94471861842982. (25.944).
The other changes are all fine.
The WFC3 site mentioned in notebook (https://www.stsci.edu/hst/instrumentation/wfc3/data-analysis/photometric-calibration/ir-photometric-calibration) said values are from 2020 "for an infinite aperture of radius 6 arcsec". stsynphot follows whatever lookup tables are available at the time (which is probably newer than 2020) and also depends on exact obsmode (see https://stsynphot.readthedocs.io/en/stable/stsynphot/appendixb_inflight.html#wfc3). |
So if you want the canonical source to be stsynphot , description also needs to be updated and you might have to add stsynphot calls to the notebook, which is probably overkill. |
If you want the values to be from 2012, then might have to update the URL because I cannot easily find 25.9463 on that page for that filter. |
Here are the 2012 values: I think it's fine to update, but we should probably use the best current value. I used an obsmode of 'wfc3,ir,f160w' which is also for an "infinite" aperture. See https://spacetelescope.github.io/hst_notebooks/notebooks/WFC3/zeropoints/zeropoints.html. It's interesting the that current calibration value is very close to the 2012 value, but the 2020 value has a larger difference. |
I also tried changing the MJD to the range spanned by the observations, but the zeropoint differences are ~1e-8. |
Weird... should we send in help call to WFC3 Team? As for the notebook, I am not sure how to modify the text to say value is from stsynphot without overcomplicating things (the PYSYN_CDBS stuff is a pain to set up if users want to reproduce it). Should I just revert the zeropoint stuff from this PR? |
Can you simply say it's the latest zeropoint from |
Sure, I can. Meanwhile, I submitted INC0206518 to HST Help Desk. |
because 2020 value is off compared to stsynphot. Co-authored-by: Larry Bradley <[email protected]>
@larrybradley , I added a commit to address your zeropoint concerns. FYI. |
Forwardport #261
Fix #263