Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum Support? #7

Open
pyrossh opened this issue Oct 4, 2016 · 1 comment
Open

Enum Support? #7

pyrossh opened this issue Oct 4, 2016 · 1 comment

Comments

@pyrossh
Copy link

pyrossh commented Oct 4, 2016

I would like to register a service using an enum value. But currently its not possible.

enum Property {
   APIEndpoint
   APIVersion
   TaxRate
}

const engine = new Container()
engine.register(Property.TaxRate, 14.0)
@asvetliakov
Copy link
Owner

asvetliakov commented Nov 6, 2016

The problem is that typescript enums are number based. Consider following:

enum First {
   FIRST,
   SECOND
}

enum Second {
   SecondFirst,
   SecondSecond
}

engine.register(First.FIRST, 10);
engine.register(Second.SecondFirst, 15);

engine.resolve(First.FIRST); // 15

There is nothing to prevent you accidentally overwrite first enum value. I'd use es6 Symbol or string literal types for that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants