Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Browser tests are failing in macos-latest due to Puppeteer #1001

Closed
smoya opened this issue Jun 4, 2024 · 2 comments
Closed

[CI] Browser tests are failing in macos-latest due to Puppeteer #1001

smoya opened this issue Jun 4, 2024 · 2 comments

Comments

@smoya
Copy link
Member

smoya commented Jun 4, 2024

Description

Current browser tests are broken in MacOS due to a timeout. See the following run as example: https://github.com/asyncapi/parser-js/actions/runs/9348904713/job/25775243162?pr=999#step:10:443

Google Chrome_PikQRSCy

I've tried increasing timeouts, but it always ends with such a timeout.
After a deep investigation, I discovered the issue happens when trying to start a new browser instance through Puppeteer.

But why this is happening suddenly?

macos-latest GitHub-hosted runner tag was migrated (through a 12 weeks of rolling update) from pointing to macos-12 to macos-14. Not that exactly, but in practical effects, that's what happened.
The issue comes with this new macos-14 version: macos-14 is now on Apple Silicon (arm64) and not Intel anymore..

Steps I follow but didn't fix the issue

  1. I decided to upgrade Puppeteer to latest version because I saw there was people complaining about an incompatibility with M2/M3 Apple chipsets. Suddenly tests on Linux were also failing due to the same timeout.

  2. TODO

Possible solutions

  1. To downgrade to macos-13, at least until we find the issue and a remediation. That would require modifying the global workflow file at https://github.com/asyncapi/.github/blob/master/.github/workflows/if-nodejs-pr-testing.yml

cc @derberg

@smoya
Copy link
Member Author

smoya commented Jun 4, 2024

Ok, I found out that Puppeteer GH project downgraded from macos-latest to macos-13 . See puppeteer/puppeteer#12326

They didn't provide any description on the PR or in the issue, so the reasons are not there but I can imagine they faced this issue so they decided to not provide support to macos 14? They have an opened issue to move back to latest version. I wrote a comment there: puppeteer/puppeteer#12327 (comment)

I guess we should downgrade to macos-13 in the meantime. @derberg

@smoya smoya changed the title [CI] Browser tests are failing in macos-latest due to the lack of Chromium binary [CI] Browser tests are failing in macos-latest due to Puppeteer Jun 5, 2024
@smoya
Copy link
Member Author

smoya commented Jun 5, 2024

We downgraded to macos-13 until the issue is solved. asyncapi/.github#301

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant