feat: add multiparser to the parserjs monorepo repository. #1036

ayushnau · 2024-07-04T15:27:55Z

Changes Added.

Added the Multiparser to the turborepo. 
Added the required scripts of the turborepo to the root package.json file.

Related issue(s)

Related to: #963

…ions + NewParser

feat: export types so any other libraries can use them

* update dependencies and add support for v3

…re(release ) back.

smoya · 2024-07-05T16:53:18Z

packages/multi-parser/package.json

+    "@asyncapi/protobuf-schema-parser": "^3.0.0",
+    "@asyncapi/raml-dt-schema-parser": "^4.0.4",
+    "parserapiv1": "npm:@asyncapi/parser@^2.1.0",
+    "parserapiv2": "npm:@asyncapi/[email protected]"


Where is the parserapiv3 ?

yes this is shifted to line number 65. as "@asyncapi/parser": "file:../parser"
which will take the latest version as a @asyncapi/parser

But why devDependency?

Actually I was thinking as the parser is in the local now will not need to keep it as dependency. but now i am thinking though the test are passing successfully it should be in dependency only. anyway updated the added it back.

ayushnau · 2024-07-08T16:59:06Z

ayushnau · 2024-07-08T16:59:15Z

@smoya please can you merge this.

smoya · 2024-07-08T19:08:52Z

@smoya can you merge this. now.

LOL i hope it is not an order 😂. Will review and merge when i have a chance. I'm out on holidays, and sick at the same time.

smoya

First review round

smoya · 2024-07-11T09:14:14Z

turbo.json

-    "build": {}
+   "test": {"cache": false},
+   "prepublishOnly": {"cache": false},
+    "test:unit": {"cache": false},


Nitpick: Does this file have a wrong indentation now?

added the correct indentation.

smoya · 2024-07-12T09:19:10Z

packages/multi-parser/package.json

+    "@asyncapi/raml-dt-schema-parser": "^4.0.4",
+    "parserapiv1": "npm:@asyncapi/parser@^2.1.0",
+    "parserapiv2": "npm:@asyncapi/[email protected]",
+    "@asyncapi/parser": "file:../parser"


Is there any reason for changing the dependency name? If there isnt, please do not modify the original code from https://github.com/smoya/multi-parser-js/blob/19750c914386d4417c9e17b13584634132805e27/package.json#L47

Previously, we used parserv3, but now that the repositories are merged and multiparser is using the latest version, it makes sense to refer to it by the correct name. If anyone needs to know the version, they can simply check the version of parser.

The reason the version was explicit is exactly because we wanted it to be explicit for each version

ping @ayushnau

ok fixed this.

smoya · 2024-07-12T09:24:22Z

How would new releases of the @asyncapi/parser affect this multi-parser package?
How shall we do releases now if we want to sync the dependency of the @asyncapi/parser in @asyncapi/multi-parser ?

ayushnau · 2024-07-12T11:29:25Z

How would new releases of the @asyncapi/parser affect this multi-parser package? How shall we do releases now if we want to sync the dependency of the @asyncapi/parser in @asyncapi/multi-parser

Now whenever @asyncapi/parser will be updated. New md file will be created in the .changeset folder stating the package and the level of change.
Now as the @asyncapi/multiparser is the directly using the local @asyncapi/parser. The dependency for the multiparser will be updated.
Now while creating the md I am suggesting to add the @asyncapi/multiparser along with the parser, as the dependency for multiparser is also changed. both package will be release together.

---
"@asyncapi/parser": minor
"@asyncapi/multi-parser": patch


changes.

yes that would mean we dont need to do anything else to sync the parser with multiparser it will be automatically synced

@smoya

smoya · 2024-07-15T09:25:00Z

How would new releases of the @asyncapi/parser affect this multi-parser package? How shall we do releases now if we want to sync the dependency of the @asyncapi/parser in @asyncapi/multi-parser

Now whenever @asyncapi/parser will be updated. New md file will be created in the .changeset folder stating the package and the level of change.

Now as the @asyncapi/multiparser is the directly using the local @asyncapi/parser. The dependency for the multiparser will be updated.

Now while creating the md I am suggesting to add the @asyncapi/multiparser along with the parser, as the dependency for multiparser is also changed. both package will be release together.
---
"@asyncapi/parser": minor
"@asyncapi/multi-parser": patch


changes.
yes that would mean we dont need to do anything else to sync the parser with multiparser it will be automatically synced

@smoya

I guess it works by now. We could work on some automation in the future for this. 👍

ayushnau · 2024-07-15T15:47:17Z

will be giving update on this by on weekend. currently cant take it.

ayushnau · 2024-07-19T07:03:36Z

@smoya updated this please check.

.changeset/wise-laws-retire.md

turbo.json

smoya

LGTM! 🚀🌔

smoya · 2024-07-23T12:23:22Z

/rtm

smoya and others added 30 commits August 18, 2023 12:52

Initial commit

f60e609

Initial commit

8aa8a81

feat: add CI/CD workflows

7ddfd58

feat!: allow converting AsyncAPIDocument to different Parser-API vers…

dd6d03b

…ions + NewParser

feat!: optionally include Schema parsers when creating a Parser

d42ea8a

feat!: change Parser-API version args to represent just the major

ae043a8

update parser-js

6a38e4a

feat!: change Parser-API version args to represent just the major

cda0912

feat: export types so any other libraries can use them

ed8efa7

feat: export types so any other libraries can use them

cd52058

feat: export types so any other libraries can use them

feat!: add support for parser API v3 (#5)

ce21a37

* update dependencies and add support for v3

fix: update parser-js to v3 (#7)

2655777

fix: update @asyncapi/parser to 3.0.6 (#8)

b9dc1d8

fix: update @asyncapi/parser to 3.0.7 (#9)

8158f9a

fix: update @asyncapi/parser to 3.0.9

94031bf

fix: update @asyncapi/parser to 3.0.12 (#13)

e4c891e

fix: update @asyncapi/parser to 3.0.13 (#14)

38763a3

web: prepare web codebase for turborepo

2e000ba

feat(create-turbo): create basic

853be5c

feat(create-turbo): apply official-starter transform

480e0ab

feat(create-turbo): apply package-manager transform

a88dd0a

initial commit

6e2463c

Merge remote-tracking branch 'parser/master'

c52d8f0

Added the required scripts for the turborepo

648aa1f

removed unwanted files.

d455df3

Added the gitignore file.

9939c51

fixed the eslintrc file.

f25d259

fix: update @asyncapi/parser to 3.0.14 (#15)

4f8f26e

Added the required changes .

7c25ae9

Added the required

dcd54eb

asyncapi-bot added the bounty AsyncAPI Bounty label Jul 5, 2024

AyushNautiyalDeveloper added 3 commits July 5, 2024 20:27

removed the requirement for the releasing with feat and added the cho…

b44928c

…re(release ) back.

added the script for the prepublishOnly.

7cb9de8

update the package.json.

eaa122a

smoya reviewed Jul 5, 2024

View reviewed changes

AyushNautiyalDeveloper added 3 commits July 6, 2024 03:40

changed the asyncapi/parser from dev dependency to dependency.

4d69744

added the private false to the multiparser.

5b2fa32

updated the files.

f3ff616

smoya requested changes Jul 12, 2024

View reviewed changes

ayushnau added 5 commits July 18, 2024 20:55

added the build script for the release

16aef3e

updated the dependency for the stoplight json.

7b07740

changed the name to parserapiv3

4fda2a4

corrected the indentation.

f10b7fc

added the build script in the test.

dfcdec6

smoya reviewed Jul 23, 2024

View reviewed changes

.changeset/wise-laws-retire.md Show resolved Hide resolved

smoya reviewed Jul 23, 2024

View reviewed changes

turbo.json Show resolved Hide resolved

smoya approved these changes Jul 23, 2024

View reviewed changes

asyncapi-bot added the ready-to-merge label Jul 23, 2024

asyncapi-bot merged commit 4556aec into asyncapi:master Jul 23, 2024
9 checks passed

ayushnau mentioned this pull request Jul 23, 2024

feat: added the changeset for the parser. #1040

Merged

smoya mentioned this pull request Jul 23, 2024

Integrate smoya/multi-parser-js into asyncapi/parser-js #963

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add multiparser to the parserjs monorepo repository. #1036

feat: add multiparser to the parserjs monorepo repository. #1036

ayushnau commented Jul 4, 2024 •

edited

Loading

smoya Jul 5, 2024

ayushnau Jul 5, 2024

smoya Jul 5, 2024

ayushnau Jul 5, 2024

ayushnau commented Jul 8, 2024

ayushnau commented Jul 8, 2024 •

edited

Loading

smoya commented Jul 8, 2024

smoya left a comment

smoya Jul 11, 2024

smoya Jul 15, 2024

ayushnau Jul 19, 2024

smoya Jul 12, 2024

ayushnau Jul 12, 2024

smoya Jul 12, 2024

smoya Jul 15, 2024

ayushnau Jul 19, 2024

smoya commented Jul 12, 2024

ayushnau commented Jul 12, 2024 •

edited

Loading

smoya commented Jul 15, 2024

ayushnau commented Jul 15, 2024

ayushnau commented Jul 19, 2024

smoya left a comment

smoya commented Jul 23, 2024

feat: add multiparser to the parserjs monorepo repository. #1036

feat: add multiparser to the parserjs monorepo repository. #1036

Conversation

ayushnau commented Jul 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ayushnau commented Jul 8, 2024

ayushnau commented Jul 8, 2024 • edited Loading

smoya commented Jul 8, 2024

smoya left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smoya commented Jul 12, 2024

ayushnau commented Jul 12, 2024 • edited Loading

smoya commented Jul 15, 2024

ayushnau commented Jul 15, 2024

ayushnau commented Jul 19, 2024

smoya left a comment

Choose a reason for hiding this comment

smoya commented Jul 23, 2024

ayushnau commented Jul 4, 2024 •

edited

Loading

ayushnau commented Jul 8, 2024 •

edited

Loading

ayushnau commented Jul 12, 2024 •

edited

Loading