Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update release workflow #939

Merged
merged 2 commits into from
Jul 25, 2023
Merged

ci: update release workflow #939

merged 2 commits into from
Jul 25, 2023

Conversation

kaushik-rishi
Copy link
Contributor

@kaushik-rishi kaushik-rishi commented May 24, 2023 •
edited
Loading

title: "Update release workflow"

Related issue(s):
Fixes #938

github-actions[bot]
github-actions bot reviewed May 24, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@kaushik-rishi kaushik-rishi marked this pull request as draft May 24, 2023 17:48
@kaushik-rishi kaushik-rishi changed the title feat: update release workflow on release branch chore: update release workflow on release branch May 24, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kaushik-rishi kaushik-rishi marked this pull request as ready for review May 25, 2023 02:58
@derberg derberg changed the title chore: update release workflow on release branch ci: update release workflow on release branch Jun 28, 2023
@derberg
Copy link
Member

derberg commented Jun 29, 2023

@kaushik-rishi sorry for looking into it so late

ci: update release workflow on release branch - it is not correct. You are targeting master, not release branch.

  • Just update the title to ci: update release workflow and we can merge this PR if it is already in place
  • Please open another PR that modifies release workflow located in next-major-spec branch, and new PR ci: update release workflow on release branch should target next-major-spec

@kaushik-rishi
Copy link
Contributor Author

Sure @derberg

@derberg
Copy link
Member

derberg commented Jul 20, 2023

@kaushik-rishi please have a look so we can merge the fix. Unfortunately current release workflow do not work

@derberg derberg mentioned this pull request Jul 20, 2023
Merged
@kaushik-rishi
Copy link
Contributor Author

Sure @derberg
Taking a look.

@kaushik-rishi kaushik-rishi changed the title ci: update release workflow on release branch ci: update release workflow Jul 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

derberg
derberg approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ping me when you have another PR ready, for next-major-spec branch

@derberg
Copy link
Member

derberg commented Jul 25, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 268d79d into asyncapi:master Jul 25, 2023
15 checks passed
@jonaslagoni jonaslagoni mentioned this pull request Dec 4, 2023
Merged
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next-major-spec.18 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@smoya
Copy link
Member

smoya commented Feb 8, 2024

@all-contributors please add @kaushik-rishi for maintenance,infra

@allcontributors allcontributors bot mentioned this pull request Feb 8, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@smoya

I've put up a pull request to add @kaushik-rishi! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@derberg derberg derberg approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@dalelane dalelane Awaiting requested review from dalelane dalelane is a code owner

@smoya smoya Awaiting requested review from smoya smoya is a code owner

@char0n char0n Awaiting requested review from char0n char0n is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-major-spec released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update release workflow in release branch
4 participants
@kaushik-rishi @derberg @asyncapi-bot @smoya