feat: add integration tests for dashboard component & community pages #1953

reachaadrika · 2023-07-14T21:01:12Z

Description

Dashboard , component mainly has following components :
1. GoodfirstIssues.js
2. GoodFirstIssuesTooltip
3. Header.js
4. Table , Filters , Row .
The flow of test for this , is that dashboard component has GoodFirstIssues component , which displays goodFirstIssues , but also Filters them according to repository and areas , and displays the filtered data in the component . It uses the Filters Component , which within itself uses Select Component . Thus the test for this involved as follows :
1. Testing if all issues are displayed in the GoodFirstIssues component .
2. Checking if Filter Menu is displayed in GoodFirstIssues , & Further check if it selects the repository , and area which are hardcoded for now ( from Select Component ) .
3. Final check was to check if only selected repos and areas are displayed .
Finally I checked if the hotTopics , is displayed correctly in the Table component .

-The data that has been utilized here is dashboard.json

NOTE : This PR also includes some fixes associated with the unit tests written for dashboard component .

Related issue(s)
fixes #1952

netlify · 2023-07-14T21:01:19Z

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`b32aece`
🔍 Latest deploy log	https://app.netlify.com/sites/asyncapi-website/deploys/64c939c88fb6d30008a93935
😎 Deploy Preview	https://deploy-preview-1953--asyncapi-website.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2023-07-14T21:03:19Z

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🔴 Performance	42
🟢 Accessibility	98
🟢 Best practices	100
🟢 SEO	100
🔴 PWA	30

Lighthouse ran on https://deploy-preview-1953--asyncapi-website.netlify.app/

… dashboard_integration_tests

…haadrika/website into dashboard_integration_tests

akshatnema · 2023-07-20T16:38:01Z

cypress/test/dashboard/Header.cy.js

+    cy.contains('View on Github')
+    cy.contains('Join on Slack')


Why did we change these tests?

akshatnema · 2023-07-20T17:07:47Z

cypress/test/pages/community/index.cy.js

+  it('should display NewsletterSubscribe',()=>{
+   cy.get('[data-testid="CommunityCard-subscribe"]').should('exist');
+   cy.get('[data-testid="NewsletterSubscribe-main"]').should('exist');
+   cy.get('[data-testid="NewsletterSubscribe-text-input"]').type("name");
+   cy.get('[data-testid="NewsletterSubscribe-email-input"]').type("[email protected]")
+   cy.get('form[name="form 1"]').should('exist');
+   cy.get('input[name="type"]').should('exist');
+   cy.get('input[name="name"]').should('exist');
+   cy.get('input[name="email"]').should('exist');
+  });


This test shouldn't be repeated for every file. Instead, make integration test for this component in NewsletterSubscribe test file. Also, mock the API response for this form.

…haadrika/website into dashboard_integration_tests

akshatnema · 2023-07-28T13:46:54Z

cypress/test/pages/community/events/index.cy.js

+      cy.get('[ data-testid="Meeting-host"]').should('exist')
+      cy.get('[ data-testid="Meeting-link"]').should('exist')
+  });
+


Add integration tests for events filter in this test file.

cypress/test/pages/community/ambassadors/index.cy.js

akshatnema · 2023-07-28T13:56:39Z

cypress/test/pages/community/ambassadors/index.cy.js

+        cy.contains('Tokens of our appreciation').should('exist');
+
+        cy.contains('We appreciate your commitment and passion for sharing your knowledge with your communities. Let us support you!')
+            .should('exist');


Instead of checking for the content, check for the respective tags, whether they are present. We are not concerned about testing the content inside the tag, we are testing whether the heading and relative content to it is present or not.

akshatnema · 2023-07-28T13:57:31Z

cypress/test/pages/community/ambassadors/index.cy.js

+        cy.contains('Become an AsyncAPI Ambassador').should('exist');
+
+        cy.contains('The AsyncAPI Ambassador program is now open for applications! If you’re selected, you’ll join AsyncAPI\'s mission of helping community members all over the world, build the future of Event-Driven APIs.')
+            .should('exist');


Don't check for content, check for the tags using data-testid.

akshatnema · 2023-07-28T13:59:14Z

cypress/test/dashboard/Header.cy.js

-    cy.get('[data-testid="Github-button"]').should('exist');
-    cy.get('[data-testid="Slack-button"]').should('exist');


These lines shouldn't be removed. We should also check for buttons using data-testid also, apart from checking it via text.

akshatnema · 2023-07-28T14:00:09Z

cypress/utils/MockApp.js

@@ -0,0 +1,27 @@
+import AppContext from "../../context/AppContext";


Specify why MockApp has been created using comments.

Co-authored-by: Akshat Nema <[email protected]>

…haadrika/website into dashboard_integration_tests

akshatnema · 2023-07-31T20:24:56Z

cypress/test/pages/community/events/index.cy.js

+  });
+
+  it('check for Events Filters' , () => {
+   cy.get('[data-testid="EventFilters-main"]').should('exist');


Kindly apply the Event filters and check whether correct events are shown or not.

akshatnema · 2023-08-01T16:59:28Z

/rtm

reachaadrika added 2 commits July 15, 2023 01:21

integration test for dashboard

36cf5b1

fixes for dashboard unit tests

1683fba

reachaadrika requested review from derberg, akshatnema, magicmatatjahu, Mayaleeeee and asyncapi-bot-eve as code owners July 14, 2023 21:01

Merge branch 'master' into dashboard_integration_tests

2d3511f

akshatnema changed the title ~~feat: adding integration tests for dashboard component~~ feat: add integration tests for dashboard component Jul 16, 2023

akshatnema added the gsoc This label should be used for issues or discussions related to ideas for Google Summer of Code label Jul 16, 2023

reachaadrika and others added 6 commits July 17, 2023 14:08

Merge branch 'master' into dashboard_integration_tests

d21f53b

Merge branch 'master' of https://github.com/reachaadrika/website into…

c9d07ea

… dashboard_integration_tests

updated test for dashboard & mockApp

e9bdc03

Merge branch 'dashboard_integration_tests' of https://github.com/reac…

1eaf47f

…haadrika/website into dashboard_integration_tests

Merge branch 'master' into dashboard_integration_tests

3d25ae8

add community pages

9ad0ca2

reachaadrika changed the title ~~feat: add integration tests for dashboard component~~ feat: add integration tests for dashboard component & community pages Jul 18, 2023

akshatnema and others added 3 commits July 18, 2023 16:05

Update formatting in test files

5049edb

Merge branch 'master' into dashboard_integration_tests

ed1d8d0

add tests for community\events

37b81e9

akshatnema requested changes Jul 20, 2023

View reviewed changes

akshatnema and others added 7 commits July 20, 2023 22:45

Resolve errors

1c69e4b

Merge branch 'master' into dashboard_integration_tests

a6d2646

Merge branch 'dashboard_integration_tests' of https://github.com/reac…

5ece9f1

…haadrika/website into dashboard_integration_tests

add events

3efcff7

completed events page

447c4bf

completed tsc page

930e5b9

removed redundant code

a2a043c

Merge branch 'master' into dashboard_integration_tests

741b3fa

akshatnema requested changes Jul 28, 2023

View reviewed changes

reachaadrika and others added 8 commits July 29, 2023 15:02

Merge branch 'master' into dashboard_integration_tests

0009188

Update cypress/test/pages/community/ambassadors/index.cy.js

8d85110

Co-authored-by: Akshat Nema <[email protected]>

add corrected data-testids for buttons

3fb3789

chanegs in ambassadors

3c778c5

refactor community/index

b1fda59

add test for EventFilters and other changes

c64241a

Merge branch 'dashboard_integration_tests' of https://github.com/reac…

95d5966

…haadrika/website into dashboard_integration_tests

add need for MockApp and MockRouter

47f12db

akshatnema reviewed Jul 31, 2023

View reviewed changes

reachaadrika and others added 3 commits August 1, 2023 19:23

Merge branch 'master' into dashboard_integration_tests

db03487

add specific event filters test

c13b3d7

Update formatting and doc comments for test files

b32aece

akshatnema approved these changes Aug 1, 2023

View reviewed changes

asyncapi-bot added the ready-to-merge label Aug 1, 2023

asyncapi-bot merged commit c5b57b3 into asyncapi:master Aug 1, 2023
11 checks passed

reachaadrika mentioned this pull request Aug 16, 2023

Adding unit tests inside community pages . #1954

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add integration tests for dashboard component & community pages #1953

feat: add integration tests for dashboard component & community pages #1953

reachaadrika commented Jul 14, 2023

netlify bot commented Jul 14, 2023 •

edited

Loading

github-actions bot commented Jul 14, 2023 •

edited

Loading

akshatnema Jul 20, 2023

reachaadrika Jul 30, 2023

akshatnema Jul 20, 2023

reachaadrika Jul 30, 2023

akshatnema Jul 28, 2023

reachaadrika Jul 30, 2023

akshatnema Jul 28, 2023

reachaadrika Jul 30, 2023

akshatnema Jul 28, 2023

reachaadrika Jul 30, 2023

akshatnema Jul 28, 2023

reachaadrika Jul 30, 2023

akshatnema Jul 28, 2023

reachaadrika Jul 30, 2023

akshatnema Jul 31, 2023

reachaadrika Aug 1, 2023

akshatnema commented Aug 1, 2023

		cy.get('[data-testid="Github-button"]').should('exist');
		cy.get('[data-testid="Slack-button"]').should('exist');

		@@ -0,0 +1,27 @@
		import AppContext from "../../context/AppContext";

feat: add integration tests for dashboard component & community pages #1953

feat: add integration tests for dashboard component & community pages #1953

Conversation

reachaadrika commented Jul 14, 2023

netlify bot commented Jul 14, 2023 • edited Loading

✅ Deploy Preview for asyncapi-website ready!

github-actions bot commented Jul 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akshatnema commented Aug 1, 2023

netlify bot commented Jul 14, 2023 •

edited

Loading

github-actions bot commented Jul 14, 2023 •

edited

Loading