Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @monaco-editor/react and @monaco-editor from package.json #1970

Closed
sambhavgupta0705 opened this issue Jul 19, 2023 · 2 comments · Fixed by #1973
Closed

Remove @monaco-editor/react and @monaco-editor from package.json #1970

sambhavgupta0705 opened this issue Jul 19, 2023 · 2 comments · Fixed by #1973

Comments

@sambhavgupta0705
Copy link
Member

sambhavgupta0705 commented Jul 19, 2023

Describe the bug

So previously we were using monaco code editor for modelina playground and as of now it has been shifted to modelina.org so we removed all monaco code editor instances but forgot to remove it from dependencies so now we just need to remove it from the package.json because we are no longer using it.

@sambhavgupta0705 sambhavgupta0705 changed the title Remove @monaco-editor/react and monaco-editor from package.json Remove @monaco-editor/react and @monaco-editor from package.json Jul 19, 2023
@sambhavgupta0705
Copy link
Member Author

/gfi javascript

@AnimeshKumar923
Copy link
Contributor

AnimeshKumar923 commented Jul 19, 2023

So what has to be done is remove this:

"@monaco-editor/react": "^3.3.0",

and this:
"monaco-editor": "^0.20.0",

from package.json. Am I right? @sambhavgupta0705

Asking so that we're clear and also, make it easy for newcomers/first-timers to contribute and get started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants