Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper layout of home page buttons in mobile view #2087

Closed
nishaaannnt opened this issue Aug 22, 2023 · 5 comments · Fixed by #2088
Closed

Improper layout of home page buttons in mobile view #2087

nishaaannnt opened this issue Aug 22, 2023 · 5 comments · Fixed by #2088
Labels

Comments

@nishaaannnt
Copy link
Contributor

Describe the bug

In mobile view the two home page buttons "Read The docs " and Search appear unevenly arranged

How to Reproduce

In mobile view the UI bug is visible in Home page

  • Screenshots
    image

Expected behavior

The buttons can be arranges in columns or can be made more visually proper.

Am happy to work on this Issue !

@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sambhavgupta0705
Copy link
Member

@nishaaannnt That's a valid issue. This error was occuring many months back but when we were reloading the site then it was working fine but now it is giving us a UI error.
Regarding #2088 the design is okayish but we can't the whole layout of button .We need to have them in the same layout with only making the size small
@derberg what are your thoughts on this

@nishaaannnt
Copy link
Contributor Author

@sambhavgupta0705 thanks for the feedback sambhav
I tried to make the buttons side by side but it didnt looked good so i thought of resolving the issue by flexing them in column.
If you want i can try the other way as well

@Mayaleeeee
Copy link
Member

@sambhavgupta0705 thanks for the feedback sambhav
I tried to make the buttons side by side but it didnt looked good so i thought of resolving the issue by flexing them in column.
If you want i can try the other way as well

Hello @nishaaannnt, could you kindly provide a visual representation of how the buttons will appear when arranged in columns?

But I feel if we make the buttons smaller, that would be nice too.

Your suggestion sounds good as well, so please feel free to show the visual representatation of the expected behavior you suggested.

Thank you.

@nishaaannnt
Copy link
Contributor Author

Hey @Mayaleeeee here is a reference image attached which actually seems proper in layout

column

Thank you for reviewing.

@akshatnema akshatnema linked a pull request Sep 30, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants