Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: footer section orientation for small screens #2742

Closed

Conversation

akkshitgupta
Copy link
Contributor

@akkshitgupta akkshitgupta commented Mar 6, 2024

Description
This pull request implements the changes based on the discussion here

Related issue(s) close : #1676

Earlier Now
image image

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5bbabd6
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/65e9385d0742430008734342
😎 Deploy Preview https://deploy-preview-2742--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Mar 6, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 36
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-2742--asyncapi-website.netlify.app/

@sambhavgupta0705
Copy link
Member

@Mayaleeeee @akkshitgupta IMO the current design on website is looking better than this one

@akkshitgupta
Copy link
Contributor Author

the current design on website is looking better than this one

I guess the current state is more visually balanced compared to the new state.
There is a concept of asymmetrical balance in designing which can be achieved with something like this

image

@Mayaleeeee
Copy link
Member

the current design on website is looking better than this one

I guess the current state is more visually balanced compared to the new state.
There is a concept of asymmetrical balance in designing which can be achieved with something like this

image

I still prefer the new one though.

It's simple and nice to follow.

@akshatnema
Copy link
Member

@akkshitgupta @Mayaleeeee These are my opinions regarding footer.
IMHO, I don't find any need to change the footer section because right now too, it is short, easy to navigate and simple. Regarding the new design, it is a bit more scrollable so I don't prefer that. And I don't think it will change anything from user's point of view that all footer elements are aligned to left.

@sambhavgupta0705
Copy link
Member

@Mayaleeeee I agree with @akshatnema 's point here

@Mayaleeeee
Copy link
Member

@Mayaleeeee I agree with @akshatnema 's point here

It's alright, then. cc @akkshitgupta @sambhavgupta0705

@sambhavgupta0705
Copy link
Member

closing this as not required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug : Footer content not correctly aligned for smaller screen sizes
5 participants