feat: add rendering of case study asyncapi document #2770
Conversation
akkshitgupta
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2770--asyncapi-website.netlify.app/ |
|
Greatwork @akkshitgupta |
|
Let's wait other maintainers' approval on this and then we are good to go |
scripts/casestudies/readyaml.js
Outdated
There was a problem hiding this comment.
add this file as part of components/helper folder, as this function is used in the UI side, not at scripts side.
|
thanks! I would prefer that you do not add new example field but reuse full example also please make sure it is visible in right hand side navigation, and not hidden in More Details |
|
@derberg please review this one |
reminder |
derberg
changed the title
|
@akkshitgupta can you please solve the merge conflict and then we can merge it |
|
The merge conflict can be complex as we have migrated the code from JS to TS.In that case you can open a new PR for this |
|
sure @sambhavgupta0705 I will look into it. |
|
@akkshitgupta are you willing to work on this or we can give it to another contributor? |
|
@sambhavgupta0705 I guess there is some confusion. I have updated the files to the typescript version already. you can check for that :) |
|
ohh my bad |
|
/rtm |
Description
This pull request adds the
Production-use AsyncAPI documentas an example on theadeocase study page. Also, updates the link action to opening the preview.yamlfile in new tab instead of downloading it.Related issue(s) Fixes #1503
Related screenshot
Video Proof
Screen.Recording.2024-03-14.at.12.25.02.AM.mov