feat: migrate open api comparison #2785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishvamsinh28
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
akshatnema
reviewed
Mar 20, 2024
components/OpenAPIComparison.tsx
Outdated
| Components: boolean; | ||
| } | ||
|
|
||
| interface Props { |
There was a problem hiding this comment.
Suggested change
| interface Props { | |
| interface OpenAPIComparisonProps { |
Rename the props variable.
akshatnema
reviewed
Mar 20, 2024
components/OpenAPIComparison.tsx
Outdated
| <div className={ `${ className } flex flex-wrap text-center` }> | ||
| <div className='mr-1 flex-1 border border-black p-2'> | ||
| <h3 className='mb-4 ml-2 font-sans text-lg font-medium'>OpenAPI 3.0</h3> | ||
|
|
There was a problem hiding this comment.
Avoid unnecessary line breaks.
|
@vishvamsinh28 resolve the lint errors. |
akshatnema
approved these changes
Mar 27, 2024
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrated OpenAPIComparisonV3.js and OpenAPIComparison.js