fix: fixed duplicate scroll button Issue in safari browser #3392
Conversation
Prathamesh-V-Kirad
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3392--asyncapi-website.netlify.app/ |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
components/buttons/ScrollButton.tsx (1)
30-35: Consider these accessibility and UX improvements.While the fix works, we can enhance the implementation with:
- Accessibility improvements
- Smooth transitions
<button - className={`rounded-full bg-white shadow-md ${backToTopButton ? 'visible' : 'pointer-events-none invisible'}`} + className={`rounded-full bg-white shadow-md transition-opacity duration-200 ${ + backToTopButton ? 'visible opacity-100' : 'pointer-events-none invisible opacity-0' + }`} + aria-hidden={!backToTopButton} + aria-label="Scroll to top of page" onClick={scrollUp} > - <img src={scrollImage} alt='scroll to top' /> + <img src={scrollImage} alt="" role="presentation" /> </button>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
components/buttons/ScrollButton.tsx(1 hunks)
🔇 Additional comments (2)
components/buttons/ScrollButton.tsx (2)
30-35: LGTM! The visibility control fix should resolve the Safari issue.
The switch from conditional rendering to CSS-based visibility control is a good approach to prevent duplicate buttons from appearing during scroll events in Safari.
30-35: Verify the fix across different Safari versions.
Let's ensure the solution works consistently across various Safari versions and scroll behaviors.
| </button> | ||
| )} | ||
| <button | ||
| className={`rounded-full bg-white shadow-md ${backToTopButton ? 'visible' : 'pointer-events-none invisible'}`} |
There was a problem hiding this comment.
Kind of confused as how these changes are leading to fix the error in safari?
There was a problem hiding this comment.
The issue was due to an empty true condition, which led to unexpected behavior, img copies in DOM, By updating this condition to execute a specific action when true, we effectively resolved the issue as highlighted by codeRabbit. The issue and solution videos illustrate this difference clearly.
Description
ScrollButton.tsxScreen.Recording.2024-11-13.at.9.30.59.PM.mov
Related issue(s)
Fixes #3197
Summary by CodeRabbit
ScrollButtoncomponent for better visibility and interactivity as users scroll.