You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the code for Github , X , Linkedin Icon for the TSC member cards on /community/tsc page have been written in a way that uses the useState() hook and onMouseEnter() / onMouseLeave() .
This is unnecessary because hover: in tailwind does it by default.
This additional state changing overhead can be removed to optimize this piece of code .
How will this change help?
On /community/tsc page , only these icons are using useState() which is not required for hover.
Removing this can turn this into a server component and thus improving performance
Screenshots
Current code using useState() for hover.
Refactored code that will still work fill without needing to use useState().
How could it be implemented/designed?
The hover feature would just work fine as it used to if the state implementation is removed.
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
SahilDahekar
changed the title
[FEATURE] The code hover effect on TSC member cards doesn't need to use state.
[REFACTOR] The code hover effect on TSC member cards doesn't need to use state.
Nov 28, 2024
Why do we need this improvement?
/community/tsc
page have been written in a way that uses theuseState()
hook andonMouseEnter()
/onMouseLeave()
.hover:
in tailwind does it by default.How will this change help?
/community/tsc
page , only these icons are usinguseState()
which is not required for hover.Screenshots
Current code using
useState()
for hover.Refactored code that will still work fill without needing to use
useState()
.How could it be implemented/designed?
The hover feature would just work fine as it used to if the state implementation is removed.
🚧 Breaking changes
No
👀 Have you checked for similar open issues?
🏢 Have you read the Contributing Guidelines?
Are you willing to work on this issue?
Yes I am willing to submit a PR!
The text was updated successfully, but these errors were encountered: