Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a --fit flag #101

Open
raldone01 opened this issue Jul 31, 2022 · 0 comments
Open

Consider adding a --fit flag #101

raldone01 opened this issue Jul 31, 2022 · 0 comments

Comments

@raldone01
Copy link

I used tiv in the past. I now wanted to optionally support viu.
In tiv -h -w are max height/max width. I think this is what most expect.

My use case:
I use tiv and viu in my fish_greeting function on all my linux machines (shell script).

Image using tiv:
tiv

Same image using viu:
viu

I don't think changing the behaviour would be an issue for many users.
To avoid doing a breaking change I would suggest adding a --fit option that changes the behaviour to make -h and -w max measurements instead.
Alternatively you can also reconsider #55.

I also noticed that the colors are off in viu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant