From a0294805d2feddf40d33f286e0fad670b58c90b8 Mon Sep 17 00:00:00 2001
From: Suman Das <59254445+sumandas0@users.noreply.github.com>
Date: Wed, 5 Jun 2024 09:54:27 +0530
Subject: [PATCH] nit: make all namings descriptive

---
 .../store/graph/AtlasEntityStore.java         |  3 +--
 .../store/graph/v2/AtlasEntityStoreV2.java    |  2 +-
 .../org/apache/atlas/web/rest/EntityREST.java | 24 ++++++++++++++++---
 3 files changed, 23 insertions(+), 6 deletions(-)

diff --git a/repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java b/repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
index d072139aef..912799cdd6 100644
--- a/repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
+++ b/repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
@@ -25,7 +25,6 @@
 import org.apache.atlas.model.instance.AtlasEntity.AtlasEntitiesWithExtInfo;
 import org.apache.atlas.model.instance.AtlasEntity.AtlasEntityWithExtInfo;
 import org.apache.atlas.model.instance.AtlasEntityHeader;
-import org.apache.atlas.model.instance.AtlasEntityHeaders;
 import org.apache.atlas.model.instance.AtlasObjectId;
 import org.apache.atlas.model.instance.AtlasHasLineageRequests;
 import org.apache.atlas.model.instance.EntityMutationResponse;
@@ -364,6 +363,6 @@ EntityMutationResponse deleteByUniqueAttributes(List<AtlasObjectId> objectIds)
 
     void repairMeaningAttributeForTerms(List<String> termGuids) throws AtlasBaseException;
 
-    public void repairAlias(String guid) throws AtlasBaseException;
+    void repairAccesscontrolAlias(String guid) throws AtlasBaseException;
 
 }
diff --git a/repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java b/repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
index 7df859eb99..037fadbc17 100644
--- a/repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
+++ b/repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
@@ -2709,7 +2709,7 @@ private void repairMeanings(AtlasVertex assetVertex) {
 
     }
     @Override
-    public void repairAlias(String guid) throws AtlasBaseException {
+    public void repairAccesscontrolAlias(String guid) throws AtlasBaseException {
         AtlasPerfMetrics.MetricRecorder metric = RequestContext.get().startMetricRecord("repairAlias");
         // Fetch accesscontrolEntity with extInfo
         AtlasEntity.AtlasEntityWithExtInfo accesscontrolEntity = entityRetriever.toAtlasEntityWithExtInfo(guid);
diff --git a/webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java b/webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java
index 31283924a2..7669b07839 100644
--- a/webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java
+++ b/webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java
@@ -1932,9 +1932,27 @@ public void repairIndexByTypeName(@PathParam("typename") String typename, @Query
     }
 
     @POST
-    @Path("/repairalias/{guid}")
+    @Path("/repairAccesscontrolAlias/{guid}")
     @Timed
-    public void repairAlias(@PathParam("guid") String guid) throws AtlasBaseException {
-        entitiesStore.repairAlias(guid);
+    public void repairAccessControlAlias(@PathParam("guid") String guid) throws AtlasBaseException {
+        Servlets.validateQueryParamLength("guid", guid);
+
+        AtlasPerfTracer perf = null;
+
+
+       try {
+           if (AtlasPerfTracer.isPerfTraceEnabled(PERF_LOG)) {
+               perf = AtlasPerfTracer.getPerfTracer(PERF_LOG, "EntityREST.repairAccessControlAlias");
+           }
+
+           entitiesStore.repairAccesscontrolAlias(guid);
+
+           LOG.info("Repaired access control alias for entity with guid {}", guid);
+
+       } finally {
+              AtlasPerfTracer.log(perf);
+       }
+
+
     }
 }