From 539ca0540dc1855aef970ea6341a65623c550467 Mon Sep 17 00:00:00 2001 From: Rittik Dasgupta Date: Tue, 5 Nov 2024 12:02:37 +0530 Subject: [PATCH] enhancement(comment): remove deprecation callout from renderDownstreamAssetsComment --- dist/index.js | 15 +++++---------- src/utils/create-comment.js | 15 +++++---------- 2 files changed, 10 insertions(+), 20 deletions(-) diff --git a/dist/index.js b/dist/index.js index b09b895..f8aa663 100644 --- a/dist/index.js +++ b/dist/index.js @@ -17945,26 +17945,19 @@ ${downstreamAssets.hasMore ? `[See more downstream assets at Atlan](${create_com // Generating the "View asset in Atlan" button const viewAssetButton = `${getImageURL("atlan-logo", 15, 15)} [View asset in Atlan](${create_comment_ATLAN_INSTANCE_URL}/assets/${asset.guid}/overview?utm_source=dbt_github_action)`; - // Deprecation callout - const deprecationCallout = `:warning: Deprecation Notice: This action is scheduled for deprecation and will no longer be supported after June 2025. To ensure a smooth transition and continued functionality, please migrate to atlan-action by following the migration guide available [here](https://ask.atlan.com/hc/en-us/articles/11121331752719).` - // Generating the final comment based on the presence of downstream assets if (downstreamAssets.entities.length > 0) { return `${assetInfo} ${downstreamTable} -${viewAssetButton} - -${deprecationCallout}`; +${viewAssetButton}`; } else { return `${assetInfo} No downstream assets found. -${viewAssetButton} - -${deprecationCallout}`; +${viewAssetButton}`; } } @@ -17988,8 +17981,10 @@ async function createIssueComment(octokit, context, content, comment_id = null, const {pull_request} = context.payload; // Deprecation callout - const deprecationCallout = `:warning: Deprecation Notice: This action is scheduled for deprecation and will no longer be supported after June 2025. To ensure a smooth transition and continued functionality, please migrate to atlan-action by following the migration guide available [here](https://ask.atlan.com/hc/en-us/articles/11121331752719).` + let deprecationCallout = `:warning: Deprecation Notice: This action is scheduled for deprecation and will no longer be supported after June 2025. To ensure a smooth transition and continued functionality, please migrate to atlan-action by following the migration guide available [here](https://ask.atlan.com/hc/en-us/articles/11121331752719).` + deprecationCallout = "\n\n---\n\n" + deprecationCallout; + content = ` ${content} diff --git a/src/utils/create-comment.js b/src/utils/create-comment.js index 9ceb780..e16afb6 100644 --- a/src/utils/create-comment.js +++ b/src/utils/create-comment.js @@ -119,26 +119,19 @@ ${downstreamAssets.hasMore ? `[See more downstream assets at Atlan](${ATLAN_INST // Generating the "View asset in Atlan" button const viewAssetButton = `${getImageURL("atlan-logo", 15, 15)} [View asset in Atlan](${ATLAN_INSTANCE_URL}/assets/${asset.guid}/overview?utm_source=dbt_github_action)`; - // Deprecation callout - const deprecationCallout = `:warning: Deprecation Notice: This action is scheduled for deprecation and will no longer be supported after June 2025. To ensure a smooth transition and continued functionality, please migrate to atlan-action by following the migration guide available [here](https://ask.atlan.com/hc/en-us/articles/11121331752719).` - // Generating the final comment based on the presence of downstream assets if (downstreamAssets.entities.length > 0) { return `${assetInfo} ${downstreamTable} -${viewAssetButton} - -${deprecationCallout}`; +${viewAssetButton}`; } else { return `${assetInfo} No downstream assets found. -${viewAssetButton} - -${deprecationCallout}`; +${viewAssetButton}`; } } @@ -162,8 +155,10 @@ export async function createIssueComment(octokit, context, content, comment_id = const {pull_request} = context.payload; // Deprecation callout - const deprecationCallout = `:warning: Deprecation Notice: This action is scheduled for deprecation and will no longer be supported after June 2025. To ensure a smooth transition and continued functionality, please migrate to atlan-action by following the migration guide available [here](https://ask.atlan.com/hc/en-us/articles/11121331752719).` + let deprecationCallout = `:warning: Deprecation Notice: This action is scheduled for deprecation and will no longer be supported after June 2025. To ensure a smooth transition and continued functionality, please migrate to atlan-action by following the migration guide available [here](https://ask.atlan.com/hc/en-us/articles/11121331752719).` + deprecationCallout = "\n\n---\n\n" + deprecationCallout; + content = ` ${content}