Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into type annotations #55

Open
sajith opened this issue Sep 9, 2022 · 2 comments · Fixed by #153
Open

Look into type annotations #55

sajith opened this issue Sep 9, 2022 · 2 comments · Fixed by #153
Assignees
@sajith
Labels
ci/cd

Comments

@sajith
Copy link
Member

sajith commented Sep 9, 2022

It would be helpful for the human reader if the datamodel's API has PEP 484 type annotations. We could also add mypy or pytypes into a CI step.
@sajith sajith added the ci/cd label Sep 9, 2022
@sajith sajith self-assigned this Sep 9, 2022
@YufengXin YufengXin linked a pull request Oct 4, 2024 that will close this issue
fix a typo in a test request json #153
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in @sajith's project board Oct 24, 2024
@sajith
Copy link
Member Author

sajith commented Oct 25, 2024

@YufengXin This issue is about adding Python type annotations (which should help with code readability, correctness, code completion in IDEs etc) but the linked issue is unrelated. Can we keep this open until we make some progress with adding type annotations? Some of that should happen with #144.

@YufengXin YufengXin reopened this Oct 25, 2024
@YufengXin
Copy link
Collaborator

@sajith Welcome back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sajith sajith

Labels
ci/cd
Projects
@sajith's project board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix a typo in a test request json atlanticwave-sdx/datamodel
2 participants
@sajith @YufengXin