You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
They need better test coverage as well. It would be good to avoid that duplication, and move them somewhere common, and add some tests. These are the options we considered in a discussion:
Refactor the common code into a new "sdx-base" library. Downside is that we'll have to manage yet another repository.
Have sdx-lc use the modules from sdx-controller. That will probably make sdx-controller a libary, which probably is an okay trade-off. We get to develop and test these common modules in one place. We can use the same MQ and DB instances used by sdx-controller when developing and testing these modules.
Move the modules here in datamodel, and then rename "datamodel" to "sdx-base", to reflect the fact that it is not just datamodels anymore. But then we will need to use an MQ and a DB when adding integration tests.
Of these, option 1 is the least favored one. Option 3 appears to be a little more preferable than option 2, but option 3 is also a little inconvenient.
The text was updated successfully, but these errors were encountered:
Both sdx-controller and sdx-lc has some duplicated code related to DB handling and messaging:
They need better test coverage as well. It would be good to avoid that duplication, and move them somewhere common, and add some tests. These are the options we considered in a discussion:
Of these, option 1 is the least favored one. Option 3 appears to be a little more preferable than option 2, but option 3 is also a little inconvenient.
The text was updated successfully, but these errors were encountered: