Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common modules to datamodel, and rename datamodel accordingly #78

Open
sajith opened this issue Mar 1, 2023 · 0 comments
Open
Assignees

Comments

@sajith
Copy link
Member

sajith commented Mar 1, 2023

Both sdx-controller and sdx-lc has some duplicated code related to DB handling and messaging:

They need better test coverage as well. It would be good to avoid that duplication, and move them somewhere common, and add some tests. These are the options we considered in a discussion:

  1. Refactor the common code into a new "sdx-base" library. Downside is that we'll have to manage yet another repository.
  2. Have sdx-lc use the modules from sdx-controller. That will probably make sdx-controller a libary, which probably is an okay trade-off. We get to develop and test these common modules in one place. We can use the same MQ and DB instances used by sdx-controller when developing and testing these modules.
  3. Move the modules here in datamodel, and then rename "datamodel" to "sdx-base", to reflect the fact that it is not just datamodels anymore. But then we will need to use an MQ and a DB when adding integration tests.

Of these, option 1 is the least favored one. Option 3 appears to be a little more preferable than option 2, but option 3 is also a little inconvenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant