-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HL-1205 Postgres support #55
base: master
Are you sure you want to change the base?
Changes from 4 commits
7abd49d
0687e30
eafddce
0fdbc05
8659d8f
ed64ea7
beab858
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
package com.atlassian.performance.tools.infrastructure.api.database | ||
|
||
import com.atlassian.performance.tools.infrastructure.DockerImage | ||
import com.atlassian.performance.tools.infrastructure.api.dataset.DatasetPackage | ||
import com.atlassian.performance.tools.ssh.api.SshConnection | ||
import org.apache.logging.log4j.LogManager | ||
import org.apache.logging.log4j.Logger | ||
import java.net.URI | ||
import java.time.Duration | ||
|
||
class PostgresDatabase( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you can avoid the |
||
private val source: DatasetPackage, | ||
private val maxConnections: Int, | ||
private val dataBaseVersion: String | ||
) : Database { | ||
private val logger: Logger = LogManager.getLogger(this::class.java) | ||
|
||
private val image: DockerImage = DockerImage( | ||
name = "postgres:$dataBaseVersion", | ||
pullTimeout = Duration.ofMinutes(5) | ||
) | ||
|
||
constructor( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please consider builder instead of telescoping constructors and default params. See https://github.com/wyrzyk/java-api-design-checklist/blob/master/CHECKLIST.md#3612-consider-a-builder-when-faced-with-many-constructor-parameters |
||
source: DatasetPackage, | ||
dataBaseVersion: String = "9.6" | ||
dagguh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
) : this( | ||
source = source, | ||
maxConnections = 200, | ||
dataBaseVersion = dataBaseVersion | ||
) | ||
|
||
override fun setup(ssh: SshConnection): String { | ||
val pgData = source.download(ssh) | ||
image.run( | ||
ssh = ssh, | ||
parameters = "-p 3306:5432 -v `realpath $pgData`:/var/lib/postgresql/data", | ||
arguments = "-c 'listen_addresses='*'' -c 'max_connections=$maxConnections'" | ||
dagguh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
) | ||
return pgData | ||
} | ||
|
||
override fun start(jira: URI, ssh: SshConnection) { | ||
// TODO Check logs for the following entry | ||
// LOG: database system is ready to accept connections | ||
Thread.sleep(Duration.ofSeconds(15).toMillis()) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This sleep is suspicious too. How do we resolve the TODO?
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sleep is enough here, postgres databases are initialising very quickly, checking logs is something nice to have |
||
} | ||
|
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,11 @@ class FileArchiver { | |
) { | ||
ubuntu.install(connection, listOf("lbzip2")) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't have to install lbzip2 in case we're not using it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thanks for pointing this out |
||
time("unzip") { | ||
connection.execute("tar -I lbzip2 -xf $archive", timeout) | ||
val cmd = if (archive.contains("SCALED_ISSUES_UNIMODAL_PG")) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this change related to "Postgres support"? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes sir, I keep data sets for PG here - https://s3.console.aws.amazon.com/s3/buckets/jpt-pgdata/?region=eu-central-1&tab=overview |
||
"tar -xzvf $archive" | ||
else | ||
"tar -I lbzip2 -xf $archive" | ||
connection.execute(cmd, timeout) | ||
} | ||
} | ||
|
||
|
@@ -35,7 +39,11 @@ class FileArchiver { | |
) { | ||
ubuntu.install(connection, listOf("lbzip2")) | ||
time("unzip") { | ||
connection.execute("tar -I lbzip2 -xf $archive -C $destination", timeout).output.splitToSequence("\n").asIterable() | ||
val cmd = if (archive.contains("SCALED_ISSUES_UNIMODAL_PG")) | ||
"tar -xzvf $archive -C $destination" | ||
else | ||
"tar -I lbzip2 -xf $archive -C $destination" | ||
connection.execute(cmd, timeout).output.splitToSequence("\n").asIterable() | ||
} | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll mark the release after it happens, so you can remove this header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More precisely, remove the entire changelog diff except for the actual change you're shipping: