Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resupport trees 🌲 #1547

Open
alexreardon opened this issue Oct 21, 2019 · 10 comments
Open

Resupport trees 🌲 #1547

alexreardon opened this issue Oct 21, 2019 · 10 comments

Comments

@alexreardon
Copy link
Collaborator

In order to get 12.0 #1487 across the line, we needed to temporarily remove tree behaviours from rbd core. We would like to re-add this behaviour.

For now, we recommend you continue to use 11.x if using tree behaviour

@farzansalimian
Copy link

@alexreardon Could you update on status of this issue? Is there an estimated date for this?

@oziniak
Copy link

oziniak commented Feb 19, 2021

It's been a year. Version 13 is out and the docs still refer 12th version with

We do plan on supporting this type of behaviour again in a future minor release.

@danieldelcore
Copy link
Collaborator

danieldelcore commented May 4, 2021

Hi all 👋

There have been a lot of requests for Tree support to return to the library. As a relatively new maintainer, I don't have all of the context as to why this isn't working but I'm going to try my best to consolidate the information here so we can start to form a clear path forward.

For newcomers here's the TL;DR:

There have been several implementations of trees and hierarchical lists made by the community, check them out, but I'm not fully aware of their functionality/drawbacks (let me know 😄):

Related tickets + discussion:

@danieldelcore danieldelcore changed the title Resupport trees Resupport trees 🌲 May 4, 2021
@cmmartin
Copy link

cmmartin commented May 30, 2021

The example in the docs from @atlaskit/tree links to a private or deleted repository. Is this still open source?

@Pines-Cheng
Copy link

Any updates on this?

@Pines-Cheng
Copy link

found a single nested tree Demo:https://codesandbox.io/s/5v2yvpjn7n?file=/index.js
and can drag cross the parent node .

@100terres
Copy link
Contributor

100terres commented Feb 25, 2022

@Pines-Cheng this is something I'll try to tackle in this fork https://github.com/react-forked/dnd of rbd. I've wrote a blog post about this 🙂

@ethange7
Copy link

ethange7 commented Mar 3, 2022

Found an issue with isNestingEnabled and offsetPerLevel={0} dragging an item to an expanded node as very last child will result in an issue, the destination.index will return NaN in onDragEnd() params
The reason we are setting offset to 0 is that our designer want to style the level inside our component, I understand the offset is used to determine the which level this item will be in, but being able to fully customize the offset by ourself is also important.

@ethange7
Copy link

ethange7 commented Mar 3, 2022

One workaround is that we set the offset to maybe 16 and do a margin-left: -16px on the outmost renderItem component, but it feels hacky

@bassamIHabash
Copy link

bassamIHabash commented Jan 23, 2023

Hi All,

I'm not able to use @atlaskit/tree for the last version of react 18.2.0. are there any changes to support that ? as I did the upgrade for my project from react 16 to react 18.2.0

@alexreardon alexreardon unpinned this issue Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants