Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Autocomplete handling does not meet spec #255

Closed
Aerijo opened this issue Feb 26, 2019 · 1 comment
Closed

Autocomplete handling does not meet spec #255

Aerijo opened this issue Feb 26, 2019 · 1 comment
Assignees
@Aerijo

Comments

@Aerijo
Copy link
Contributor

Aerijo commented Feb 26, 2019

The spec says that filterText can be provided to be used as the sort and filter keys, and that label is used if it is falsey.

It currently filters on the text key of the converted completion. This value was set to the value of insertText, which can be a full on snippet and so is not a good candidate for filtering, nor following the spec at all.
@Aerijo Aerijo self-assigned this Feb 28, 2019
@Aerijo
Copy link
Contributor Author

Aerijo commented Mar 6, 2019

Closed by #262

@Aerijo Aerijo closed this as completed Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Aerijo Aerijo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Aerijo