Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved cookie based auth #253

Open
3 tasks
joepio opened this issue Oct 26, 2022 · 1 comment
Open
3 tasks

Improved cookie based auth #253

joepio opened this issue Oct 26, 2022 · 1 comment

Comments

@joepio
Copy link
Member

joepio commented Oct 26, 2022

Current implementation of cookie based auth #241 solves the most important issue (being able to view private images), but it still needs some improvements:

@rescribet
Copy link
Contributor

Cross origin cookies can't be set from JavaScript by design (major security risico), from what I can see only subdomains are a possibility. Proxying images through your own server seems like an easy solution.

By far the simplest way to invalidate authentication is to set a minimum timestamp and reject everything earlier. Though just adding an expiration is more robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants