Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drive & URL behavior #298

Open
joepio opened this issue Mar 1, 2023 · 1 comment
Open

Drive & URL behavior #298

joepio opened this issue Mar 1, 2023 · 1 comment

Comments

@joepio
Copy link
Member

joepio commented Mar 1, 2023

Currently, the selected Drive does not have anything to do with the URL. Sometimes this is good, but it can also be confusing.

Example:

  • Set any custom drive as your current drive
  • Close the tab
  • open AtomicData.dev (root URL) you might start with some other drive in the sidebar, while the main windows shows the AtomicData.dev drive

Some ideas:

  • When opening a home route, navigate to the last visited drive / last visited resource. This is notion's behavior.
  • When opening a resource on another drive, switch the current drive. Maybe offer a back button. Or maybe open non-current drive resources on a modal or something?
  • Store current drive in query parameter, if it differs from the origin. But this leads to very long URLs, I don't like.
@Polleps
Copy link
Member

Polleps commented Mar 1, 2023

When opening a home route, navigate to the last visited drive / last visited resource. This is notion's behavior.

This is already the current behaviour if i'm not mistaken
Edit: Apparently only the last drive was remembered but not the resource since it will load the drive as resource. This might make it difficult to determine wether to show the previous resource or the actual home route drive

When opening a resource on another drive, switch the current drive. Maybe offer a back button. Or maybe open non-current drive resources on a modal or something?

Definitely worth trying to see if it makes more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants