Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stacktrace should be always a list? #1247

Open
bettio opened this issue Aug 17, 2024 · 0 comments
Open

stacktrace should be always a list? #1247

bettio opened this issue Aug 17, 2024 · 0 comments

Comments

@bettio
Copy link
Collaborator

bettio commented Aug 17, 2024

When compiling with AVM_CREATE_STACKTRACES=off, undefined is given as stacktrace.
We should ivnestigate if this might be completely unexpected, and break any existing code (e.g. Elixir Exception module and blame functions).

If undefined can't be used, test_raw_raise must be updated accordingly.

bettio added a commit to bettio/AtomVM-fork that referenced this issue Aug 17, 2024
When using AVM_CREATE_STACKTRACES=off undefined is used as stacktrace
value, making `test_raw_raise` fail.

Since it is a known behavior also accept it, but this behavior should be
checked and reviewed (e.g. `[]` might be used instead as stack trace
value).

See also atomvm#1247

Signed-off-by: Davide Bettio <[email protected]>
bettio added a commit that referenced this issue Aug 17, 2024
Make `test_raw_raise` pass

Accept `undefined` as stacktrace value. This might be changed in the future.

See also #1247

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant