From 56e318f4aadcd91ed306a786771f899d0ceecc94 Mon Sep 17 00:00:00 2001 From: XavierChanth Date: Tue, 17 Dec 2024 09:02:35 -0500 Subject: [PATCH] chore: address review comments & cleanup work --- packages/atclient/include/atclient/monitor.h | 5 ----- tests/functional_tests/tests/test_atclient_get_atkeys.c | 1 - 2 files changed, 6 deletions(-) diff --git a/packages/atclient/include/atclient/monitor.h b/packages/atclient/include/atclient/monitor.h index b61288a9..db57877e 100644 --- a/packages/atclient/include/atclient/monitor.h +++ b/packages/atclient/include/atclient/monitor.h @@ -10,11 +10,6 @@ extern "C" { #include // IWYU pragma: keep #include -// HACK let's just get it working for now this is so wrong -#ifndef MBEDTLS_ERR_SSL_TIMEOUT -#define MBEDTLS_ERR_SSL_TIMEOUT -37 -#endif - /** * @brief Represents a message received from the monitor connection, typically derived from the prefix of the response * (e.g. "data:ok"'s message type would be "data" = ATCLIENT_MONITOR_MESSAGE_TYPE_DATA_RESPONSE) diff --git a/tests/functional_tests/tests/test_atclient_get_atkeys.c b/tests/functional_tests/tests/test_atclient_get_atkeys.c index 58b85198..61432979 100644 --- a/tests/functional_tests/tests/test_atclient_get_atkeys.c +++ b/tests/functional_tests/tests/test_atclient_get_atkeys.c @@ -144,7 +144,6 @@ exit: { static int test_4_atclient_get_atkeys_null_regex(atclient *ctx, const char *scan_regex, const bool showhidden) { int ret = 1; - return 0; // NOTE: disabled temporarily DONT LET THIS GET MERGED atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_DEBUG, "test_4_atclient_get_atkeys_null_regex\n");